Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog: local mode specific UI adjustments #2611

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jan 17, 2022

  • adjust landing page
  • disable queries tab and package manipulation ui (buttons)

TODO

@nl0 nl0 requested a review from fiskus January 17, 2022 09:37
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #2611 (dfc86ea) into master (8914292) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head dfc86ea differs from pull request most recent head a551aa2. Consider uploading reports for the commit a551aa2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2611      +/-   ##
==========================================
- Coverage   41.99%   41.98%   -0.02%     
==========================================
  Files         532      532              
  Lines       24589    24599      +10     
  Branches     3331     3334       +3     
==========================================
  Hits        10327    10327              
- Misses      13497    13507      +10     
  Partials      765      765              
Flag Coverage Δ
api-python 90.26% <ø> (ø)
catalog 13.42% <0.00%> (-0.01%) ⬇️
lambda 87.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...iners/Bucket/PackageRevisions/PackageRevisions.tsx 0.00% <0.00%> (ø)
catalog/app/utils/BucketPreferences.tsx 0.00% <0.00%> (ø)
...g/app/website/pages/Landing/LocalMode/LocalMode.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8914292...a551aa2. Read the comment docs.

Copy link
Member

@fiskus fiskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, but I didn't check it live

@nl0 nl0 merged commit 0eb4f4b into master Jan 17, 2022
@nl0 nl0 deleted the local-mode-specific-ui branch January 17, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants