-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preview rendering inside packages, refactor logic related to view modes #2328
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2328 +/- ##
==========================================
- Coverage 44.04% 44.03% -0.02%
==========================================
Files 490 490
Lines 23905 23879 -26
Branches 3060 3055 -5
==========================================
- Hits 10530 10515 -15
+ Misses 12534 12528 -6
+ Partials 841 836 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -1,136 +1,164 @@ | |||
/** | |||
* @jest-environment jsdom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is obsolete since you don't use window.fetch anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm maybe
Description
TODO