Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 for non-existing logical key #2307

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

kevinemoore
Copy link
Contributor

@kevinemoore kevinemoore commented Aug 18, 2021

Description

Pkgselect should not crash and return a proper error response when queried for details of a non-existing logical key.

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
  • Changelog entry

Pkgselect should not crash and return a proper error response when queried for details of a non-existing logical key.
@kevinemoore kevinemoore requested review from nl0 and akarve August 18, 2021 19:33
Copy link
Member

@akarve akarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but you need a CHANGELOG entry

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #2307 (8676f5b) into master (fea1f5f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2307      +/-   ##
==========================================
+ Coverage   44.22%   44.26%   +0.04%     
==========================================
  Files         488      488              
  Lines       23548    23566      +18     
  Branches     3011     3011              
==========================================
+ Hits        10414    10432      +18     
  Misses      12281    12281              
  Partials      853      853              
Flag Coverage Δ
api-python 89.82% <ø> (ø)
catalog 14.60% <ø> (ø)
lambda 94.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lambdas/pkgselect/index.py 91.02% <100.00%> (+0.35%) ⬆️
lambdas/pkgselect/test/test_pkgselect.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea1f5f...8676f5b. Read the comment docs.

@kevinemoore kevinemoore marked this pull request as ready for review August 18, 2021 22:56
@kevinemoore kevinemoore merged commit 4bf54ad into master Aug 19, 2021
@kevinemoore kevinemoore deleted the pkgselect-non-existing-logical-key branch August 19, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants