Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify package creation / update dialogs (add s3 file picker to package creation dialog) #2302

Merged
merged 16 commits into from
Aug 18, 2021

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Aug 13, 2021

Description

Use FilesInput in package creation dialog to support adding files from s3 + refactor package creation dialog to share most of the logic with package update dialog.

TODO

  • use proper copy and visual treatment for creation vs update dialog
  • fix a bug with creation dialog state not being reset
  • Changelog entry

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #2302 (c9eccfd) into master (581e11d) will increase coverage by 0.18%.
The diff coverage is 2.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
+ Coverage   44.04%   44.22%   +0.18%     
==========================================
  Files         485      488       +3     
  Lines       23650    23548     -102     
  Branches     3045     3011      -34     
==========================================
- Hits        10416    10414       -2     
+ Misses      12360    12281      -79     
+ Partials      874      853      -21     
Flag Coverage Δ
api-python 89.82% <ø> (ø)
catalog 14.60% <2.07%> (+0.08%) ⬆️
lambda 93.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/JsonEditor/JsonEditor.tsx 23.80% <ø> (ø)
catalog/app/containers/Auth/urqlExchange.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/PackageCopyDialog.js 0.00% <0.00%> (ø)
...alog/app/containers/Bucket/PackageCreateDialog.tsx 0.00% <0.00%> (ø)
...pp/containers/Bucket/PackageDialog/DialogError.tsx 0.00% <0.00%> (ø)
.../containers/Bucket/PackageDialog/DialogLoading.tsx 0.00% <0.00%> (ø)
.../containers/Bucket/PackageDialog/DialogSuccess.tsx 0.00% <0.00%> (ø)
...app/containers/Bucket/PackageDialog/FilesInput.tsx 0.00% <0.00%> (ø)
...iners/Bucket/PackageDialog/PackageCreationForm.tsx 0.00% <0.00%> (ø)
...og/app/containers/Bucket/PackageDialog/Uploads.tsx 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 581e11d...c9eccfd. Read the comment docs.

@nl0 nl0 force-pushed the s3-file-picker-in-create-pkg-dialog branch from 2eaa66e to 8a30666 Compare August 18, 2021 14:20
@nl0 nl0 requested a review from fiskus August 18, 2021 14:22
Copy link
Member

@fiskus fiskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nl0
Copy link
Member Author

nl0 commented Aug 18, 2021

@nl0 nl0 marked this pull request as ready for review August 18, 2021 17:09
@nl0 nl0 merged commit fea1f5f into master Aug 18, 2021
@nl0 nl0 deleted the s3-file-picker-in-create-pkg-dialog branch August 18, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants