-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify package creation / update dialogs (add s3 file picker to package creation dialog) #2302
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
+ Coverage 44.04% 44.22% +0.18%
==========================================
Files 485 488 +3
Lines 23650 23548 -102
Branches 3045 3011 -34
==========================================
- Hits 10416 10414 -2
+ Misses 12360 12281 -79
+ Partials 874 853 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2eaa66e
to
8a30666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backlogging performance investigation |
Description
Use FilesInput in package creation dialog to support adding files from s3 + refactor package creation dialog to share most of the logic with package update dialog.
TODO