Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: PDF: dont count pages #2276

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Preview: PDF: dont count pages #2276

merged 2 commits into from
Jul 16, 2021

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jul 15, 2021

TODO

@nl0 nl0 requested review from fiskus and akarve July 15, 2021 19:30
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2276 (dc9c19a) into master (d5b37ba) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2276   +/-   ##
=======================================
  Coverage   44.19%   44.20%           
=======================================
  Files         489      489           
  Lines       23530    23525    -5     
  Branches     3010     3008    -2     
=======================================
  Hits        10400    10400           
+ Misses      12246    12243    -3     
+ Partials      884      882    -2     
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 14.74% <0.00%> (+<0.01%) ⬆️
lambda 93.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Preview/loaders/Pdf.js 0.00% <0.00%> (ø)
catalog/app/components/Preview/renderers/Pdf.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b37ba...dc9c19a. Read the comment docs.

@nl0 nl0 force-pushed the pdf-preview-dont-count-pages branch from 433da81 to dc9c19a Compare July 16, 2021 12:01
@nl0 nl0 merged commit 4eb2c68 into master Jul 16, 2021
@nl0 nl0 deleted the pdf-preview-dont-count-pages branch July 16, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants