Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subpackage download, frontend #2258

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Subpackage download, frontend #2258

merged 3 commits into from
Jul 12, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jul 9, 2021

Waiting for backend

  • Unit tests can't write test, because code inside large component and use HTTP request
  • Automated tests (e.g. Preflight)
  • Documentation functionality is obvious
  • Changelog entry

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2258 (7029d92) into master (41fb30d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2258      +/-   ##
==========================================
- Coverage   44.31%   44.30%   -0.01%     
==========================================
  Files         491      491              
  Lines       23462    23466       +4     
  Branches     2987     2990       +3     
==========================================
  Hits        10397    10397              
- Misses      12178    12182       +4     
  Partials      887      887              
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 14.78% <0.00%> (-0.01%) ⬇️
lambda 93.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/PackageTree.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41fb30d...7029d92. Read the comment docs.

@fiskus fiskus requested a review from nl0 July 9, 2021 07:42
@fiskus fiskus merged commit 821dee3 into master Jul 12, 2021
@fiskus fiskus deleted the subpackage-download branch July 12, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants