Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search from registry #2242

Merged
merged 5 commits into from
Jun 30, 2021
Merged

Search from registry #2242

merged 5 commits into from
Jun 30, 2021

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jun 30, 2021

TODO

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #2242 (e1a794d) into master (af354f4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2242      +/-   ##
==========================================
- Coverage   44.51%   44.50%   -0.02%     
==========================================
  Files         478      478              
  Lines       23201    23211      +10     
  Branches     2924     2924              
==========================================
  Hits        10329    10329              
- Misses      11981    11991      +10     
  Partials      891      891              
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 14.79% <0.00%> (-0.02%) ⬇️
lambda 93.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/Overview.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/PackageList.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/PackageRevisions.js 0.00% <0.00%> (ø)
...g/app/containers/Bucket/Queries/requests/search.ts 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/RevisionInfo.jsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Search.js 0.00% <0.00%> (ø)
.../app/containers/Bucket/requests/requestsUntyped.js 17.89% <0.00%> (-0.21%) ⬇️
catalog/app/containers/Search/Search.js 0.00% <0.00%> (ø)
catalog/app/embed/Search.js 0.00% <0.00%> (ø)
catalog/app/utils/search.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af354f4...e1a794d. Read the comment docs.

@nl0 nl0 requested review from fiskus and sir-sigurd June 30, 2021 15:20
@nl0 nl0 marked this pull request as ready for review June 30, 2021 15:21
@sir-sigurd sir-sigurd merged commit 89c5501 into master Jun 30, 2021
@sir-sigurd sir-sigurd deleted the search-from-registry branch June 30, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants