Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pylint #2241

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Pin pylint #2241

merged 1 commit into from
Jun 30, 2021

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Jun 30, 2021

recent pylint 2.9.0 fails with:

************* Module quilt3.main
api/python/quilt3/main.py:96:4: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
api/python/quilt3/main.py:118:4: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module quilt3.telemetry
api/python/quilt3/telemetry.py:40:39: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module build
gendocs/build.py:84:36: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module indexer.test.test_read_notebook
lambdas/es/indexer/test/test_read_notebook.py:32:4: C0206: Consider iterating with .items() (consider-using-dict-items)
lambdas/es/indexer/test/test_read_notebook.py:39:4: C0206: Consider iterating with .items() (consider-using-dict-items)
************* Module test_preview
lambdas/shared/tests/test_preview.py:81:8: C0206: Consider iterating with .items() (consider-using-dict-items)

-----------------------------------
Your code has been rated at 9.99/10

@sir-sigurd sir-sigurd marked this pull request as ready for review June 30, 2021 07:25
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #2241 (948299b) into master (4e12575) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2241   +/-   ##
=======================================
  Coverage   44.67%   44.67%           
=======================================
  Files         470      470           
  Lines       23120    23120           
  Branches     2879     2879           
=======================================
  Hits        10328    10328           
  Misses      11873    11873           
  Partials      919      919           
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 14.88% <ø> (ø)
lambda 93.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e12575...948299b. Read the comment docs.

@sir-sigurd sir-sigurd merged commit 3c56e4f into master Jun 30, 2021
@sir-sigurd sir-sigurd deleted the pin-pylint branch June 30, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant