Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceCache: cleanup released resources after a timeout (fixes logout spinner issues) #2232

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jun 24, 2021

extracted from #2212

TODO

@nl0 nl0 requested a review from fiskus June 24, 2021 09:04
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #2232 (7baec13) into master (19a8aae) will decrease coverage by 0.01%.
The diff coverage is 5.26%.

❗ Current head 7baec13 differs from pull request most recent head 8a2f711. Consider uploading reports for the commit 8a2f711 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
- Coverage   44.91%   44.90%   -0.02%     
==========================================
  Files         465      465              
  Lines       22988    22999      +11     
  Branches     2859     2861       +2     
==========================================
+ Hits        10326    10327       +1     
- Misses      11746    11754       +8     
- Partials      916      918       +2     
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 15.00% <5.26%> (-0.01%) ⬇️
lambda 93.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/utils/ResourceCache.js 20.30% <5.26%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a8aae...8a2f711. Read the comment docs.

@nl0 nl0 merged commit e249666 into master Jun 24, 2021
@nl0 nl0 deleted the fix-logout-spinner branch June 24, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants