Catalog: Bucket permissions: GraphQL

[nl0]

Description

TODO

• schema
• model definition
• wire up admin ui mutations
• write updaters / optimistic results for mutations
• normalize form input values (trim, etc)
• fetch roles for users table via graphql
• Changelog entry

[codecov]

Codecov Report

Merging #2228 (8802feb) into master (d9d287d) will decrease coverage by 0.20%.
The diff coverage is 2.85%.

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
- Coverage   44.46%   44.26%   -0.21%     
==========================================
  Files         479      491      +12     
  Lines       23229    23407     +178     
  Branches     2931     2990      +59     
==========================================
+ Hits        10329    10360      +31     
- Misses      12009    12160     +151     
+ Partials      891      887       -4     

Flag	Coverage Δ
api-python	89.85% <ø> (ø)
catalog	14.81% <2.85%> (+0.03%)	⬆️
lambda	93.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
catalog/app/containers/Admin/Buckets.tsx	0.00% <ø> (ø)
...atalog/app/containers/Admin/BucketsPermissions.tsx	0.00% <0.00%> (ø)
catalog/app/containers/Admin/RFForm.tsx	0.00% <0.00%> (ø)
...og/app/containers/Admin/RoleSelection.generated.ts	0.00% <0.00%> (ø)
catalog/app/containers/Admin/Roles.tsx	0.00% <0.00%> (ø)
...log/app/containers/Admin/RolesBuckets.generated.ts	0.00% <0.00%> (ø)
...p/containers/Admin/RolesCreateManaged.generated.ts	0.00% <0.00%> (ø)
...containers/Admin/RolesCreateUnmanaged.generated.ts	0.00% <0.00%> (ø)
...alog/app/containers/Admin/RolesDelete.generated.ts	0.00% <0.00%> (ø)
...talog/app/containers/Admin/RolesRoles.generated.ts	0.00% <0.00%> (ø)
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d287d...8802feb. Read the comment docs.

[fiskus]

I see, that you are in a hurry :)
So, I'm approving now and review later, even after merging

[nl0]

the problem with this is more fundamental -- we need a way to define form typings properly, so every field is strongly typed wrt field value, validator, initial value, errors and such (smth like this probably: https://github.com/ForbesLindesay/define-form/tree/master/packages/react-define-form), otherwise it doesnt make much sense