Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 files from selected buckets #2193

Merged
merged 4 commits into from
May 14, 2021
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented May 11, 2021

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
  • Changelog entry

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #2193 (a79fe6d) into master (92929cb) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   46.32%   46.26%   -0.07%     
==========================================
  Files         446      446              
  Lines       22173    22203      +30     
  Branches     2685     2692       +7     
==========================================
  Hits        10272    10272              
- Misses      10989    11019      +30     
  Partials      912      912              
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 15.47% <0.00%> (-0.04%) ⬇️
lambda 94.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...app/containers/Bucket/PackageDialog/FilesInput.tsx 0.00% <0.00%> (ø)
...p/containers/Bucket/PackageDialog/S3FilePicker.tsx 0.00% <0.00%> (ø)
...alog/app/containers/Bucket/PackageUpdateDialog.tsx 0.00% <0.00%> (ø)
catalog/app/utils/BucketPreferences.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92929cb...a79fe6d. Read the comment docs.

@nl0 nl0 force-pushed the add-s3-files-from-selected-buckets branch from 55e4426 to 60ccb12 Compare May 14, 2021 06:31
@nl0 nl0 marked this pull request as ready for review May 14, 2021 06:34
@nl0 nl0 requested a review from fiskus May 14, 2021 06:34
@nl0
Copy link
Member Author

nl0 commented May 14, 2021

@sir-sigurd not sure while lambda tests are failing here -- i didnt touch any related code

@nl0 nl0 merged commit a8292fb into master May 14, 2021
@nl0 nl0 deleted the add-s3-files-from-selected-buckets branch May 14, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants