Voila viewer #2163
Voila viewer #2163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2163 +/- ##
==========================================
- Coverage 46.31% 46.00% -0.31%
==========================================
Files 446 450 +4
Lines 22179 22328 +149
Branches 2682 2707 +25
==========================================
Hits 10272 10272
- Misses 11001 11145 +144
- Partials 906 911 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Alexei Mochalov <[email protected]>
| const endpoint = Config.use().registryUrl | ||
| return React.useMemo( | ||
| () => `${endpoint}/voila/voila/render/${mkSearch({ url: sign(handle) })}`, | ||
| [endpoint, handle, sign], |
There was a problem hiding this comment.
with this approach we should make sure that handle object identity doesnt change, otherwise the url will be regenerated every time new handle object is created, even if its props are unchanged. we can either pass individual props to useMemo dependencies (like [handle.bucket, handle.key, ...) or use useMemoEq since it leverages deep equality checks
| })) | ||
|
|
||
| interface ValueBase { | ||
| toString: () => string |
There was a problem hiding this comment.
i meant maybe we dont need toString() and valueOf() methods here. what do we gain using that instead of plain { key, label } objects?
There was a problem hiding this comment.
We can use any items as long as they have toString and valueOf, for example, list of strings or numbers:
<SelectDropdown options={[ 'option1', 'option2' ]} value="option1" /><SelectDropdown options={[ new Date('2020-01-01'), new Date('2020-01-02') ]} value={new Date('2020-01-01')}/>
Description
TODO
Python: Runbuild.pyfor new docstrings