Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed: load polyfills, bring back prefix filtering, load more #2153

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Apr 6, 2021

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
  • Changelog entry

@nl0 nl0 requested a review from fiskus April 6, 2021 16:51
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2153 (ef87c2f) into master (75cbb6b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head ef87c2f differs from pull request most recent head 108f12e. Consider uploading reports for the commit 108f12e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2153      +/-   ##
==========================================
- Coverage   46.30%   46.29%   -0.02%     
==========================================
  Files         434      434              
  Lines       20618    20624       +6     
  Branches     2431     2432       +1     
==========================================
  Hits         9548     9548              
- Misses      10161    10166       +5     
- Partials      909      910       +1     
Flag Coverage Δ
api-python 89.78% <ø> (ø)
catalog 16.16% <0.00%> (-0.01%) ⬇️
lambda 93.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/Listing.tsx 0.00% <ø> (ø)
catalog/app/embed/Dir.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75cbb6b...108f12e. Read the comment docs.

catalog/app/embed/Dir.js Outdated Show resolved Hide resolved
nl0 and others added 2 commits April 7, 2021 19:08
@nl0 nl0 merged commit 325b38c into master Apr 7, 2021
@nl0 nl0 deleted the fix-embed branch April 7, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants