Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi folder push #2122

Merged
merged 9 commits into from
Mar 24, 2021
Merged

Multi folder push #2122

merged 9 commits into from
Mar 24, 2021

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Mar 23, 2021

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
  • Changelog entry

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #2122 (c91e721) into master (dd5ab21) will decrease coverage by 0.05%.
The diff coverage is 13.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2122      +/-   ##
==========================================
- Coverage   46.22%   46.16%   -0.06%     
==========================================
  Files         428      429       +1     
  Lines       20441    20458      +17     
  Branches     2386     2385       -1     
==========================================
- Hits         9448     9445       -3     
- Misses      10008    10049      +41     
+ Partials      985      964      -21     
Flag Coverage Δ
api-python 89.69% <ø> (ø)
catalog 16.15% <13.63%> (-0.05%) ⬇️
lambda 92.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/Dir.tsx 0.00% <0.00%> (ø)
...log/app/containers/Bucket/PackageDialog/Layout.tsx 0.00% <0.00%> (ø)
.../containers/Bucket/PackageDialog/SubmitSpinner.tsx 0.00% <0.00%> (ø)
...talog/app/containers/Bucket/PackageDialog/index.ts 0.00% <0.00%> (ø)
...g/app/containers/Bucket/PackageDirectoryDialog.tsx 0.00% <0.00%> (ø)
...alog/app/containers/Bucket/PackageUpdateDialog.tsx 0.00% <ø> (ø)
catalog/app/containers/Bucket/errors.js 49.42% <0.00%> (-2.30%) ⬇️
catalog/app/utils/NamedRoutes.tsx 52.94% <52.94%> (ø)
catalog/app/utils/mkSearch.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5ab21...c91e721. Read the comment docs.

@nl0 nl0 force-pushed the multi-folder-push branch from bd9794a to b97e72e Compare March 23, 2021 12:15
@nl0 nl0 marked this pull request as ready for review March 23, 2021 14:38
@nl0 nl0 requested a review from fiskus March 23, 2021 14:38
Copy link
Member

@fiskus fiskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI issues:

  • Directory has cursor: pointer, file has cursor: default
  • Hard to see which entry is unselected, probably we can dim unselected one

Screenshot from 2021-03-24 09-37-45

@nl0
Copy link
Member Author

nl0 commented Mar 24, 2021

@fiskus

Directory has cursor: pointer, file has cursor: default

fixed

Hard to see which entry is unselected, probably we can dim unselected one

yep, good idea, i've implemented that

@nl0 nl0 requested a review from fiskus March 24, 2021 12:19
@nl0 nl0 merged commit 93d30c9 into master Mar 24, 2021
@nl0 nl0 deleted the multi-folder-push branch March 24, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants