-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env var to disable cache #2091
Conversation
0580061
to
059132b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2091 +/- ##
==========================================
+ Coverage 45.83% 45.94% +0.10%
==========================================
Files 420 420
Lines 19915 19954 +39
Branches 2306 2306
==========================================
+ Hits 9129 9168 +39
Misses 9796 9796
Partials 990 990
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3336358
to
fbcc915
Compare
d690986
to
803a7c9
Compare
# opened for concurrent access. | ||
with tempfile.NamedTemporaryFile(delete=False) as tmp_file: | ||
local_pkg_manifest = tmp_file.name | ||
stack.callback(os.unlink, local_pkg_manifest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little bit over-engineered... Ideally, we'd just download the manifest and immediately deserialize it, without even writing to a temporary file - or create a temporary file, but use its file descriptor instead of opening it again. But I guess that's not supported right now.
Fine for now, but would be nice to clean up some day.
803a7c9
to
28010f4
Compare
Description
TODO
PackageEntry.get_cached_path()