Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Schema defaults, second try #2053

Merged
merged 24 commits into from
Feb 8, 2021
Merged

JSON Schema defaults, second try #2053

merged 24 commits into from
Feb 8, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Feb 5, 2021

  • Move fetching JSON Schema outside form
  • Show default values in JsonEditor
  • Add default values before submit
  • Try to reduce Dialog differences as much as I can

fiskus added 23 commits February 3, 2021 10:01
@fiskus
leverage default property
be0a70e
@fiskus
cosmetic refactoring
a600617
@fiskus
move workflow to the upper level
1abcb54
@fiskus
move SchemaFetcher one level up
58f14db
@fiskus
move M.Dialog one level up
727a40a
@fiskus
Merge branch 'master' of github.com:quiltdata/quilt into schema-defau…
2c9bda7 
…lts-v2
@fiskus
minor
62f56e1
@fiskus
use Dialogs directlyg
3bd6e15
@fiskus
reduce number of conditions
3fee14c
@fiskus
move DialogSuccess to separate component
ba47fde
@fiskus
add schema Defaults setter
4b8bd6f
@fiskus
Merge branch 'master' of github.com:quiltdata/quilt into json-schema-…
716e99c 
…default-value
@fiskus
Merge branch 'json-schema-default-value' into schema-defaults-v2
4673485
@fiskus
populate value with defaults on submit
d3878fe
@fiskus
move SchemaFetcher one level up
72937d2
@fiskus
use schema defaults for Update and Copy dialogs
b779b50
@fiskus
rename back to SchemaFetcher
46d6a32
@fiskus
reuse workflow from manifest
9bcb167
@fiskus
make code less verbose
71ed8fb
@fiskus
unify API of dialogs
de260f7
@fiskus
unify Dialogs API
3a966fb
@fiskus
consider that manifest is optional
0545eef
@fiskus
Merge branch 'master' of github.com:quiltdata/quilt into schema-defau…
b006ad1 
…lts-v2
@fiskus fiskus requested a review from nl0 February 8, 2021 04:37
@fiskus fiskus merged commit dea4017 into master Feb 8, 2021
@fiskus fiskus deleted the schema-defaults-v2 branch February 8, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nl0 nl0 nl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiskus @nl0