-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory to package dialog #2040
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
==========================================
- Coverage 44.18% 43.79% -0.40%
==========================================
Files 404 406 +2
Lines 19431 19605 +174
Branches 2265 2313 +48
==========================================
Hits 8586 8586
- Misses 9798 9953 +155
- Partials 1047 1066 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. the only thing i noticed after brief testing was that one can click on the drop area and trigger file selection dialog -- i think we should disable this when the files input is disabled.
@@ -47,6 +47,8 @@ const errorDisplay = R.cond([ | |||
</M.Typography> | |||
</> | |||
), | |||
], | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohwow
FilesInput
fromPackageUpdateDialog
to its own moduleFilesInput
PackageDirectoryDialog
and re-useFilesInput
there