Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory to package dialog #2040

Merged
merged 31 commits into from
Feb 12, 2021
Merged

Directory to package dialog #2040

merged 31 commits into from
Feb 12, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Feb 1, 2021

  • Move FilesInput from PackageUpdateDialog to its own module
  • Add disabled state for FilesInput
  • Add PackageDirectoryDialog and re-use FilesInput there

@codecov-io
Copy link

codecov-io commented Feb 1, 2021

Codecov Report

Merging #2040 (19db403) into master (8373a04) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
- Coverage   44.18%   43.79%   -0.40%     
==========================================
  Files         404      406       +2     
  Lines       19431    19605     +174     
  Branches     2265     2313      +48     
==========================================
  Hits         8586     8586              
- Misses       9798     9953     +155     
- Partials     1047     1066      +19     
Flag Coverage Δ
api-python 89.36% <ø> (ø)
catalog 11.91% <0.00%> (-0.19%) ⬇️
lambda 92.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/CopyButton.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/PackageCopyDialog.js 0.00% <0.00%> (ø)
...talog/app/containers/Bucket/PackageCreateDialog.js 0.00% <0.00%> (ø)
...app/containers/Bucket/PackageDialog/DialogError.js 0.00% <ø> (ø)
.../app/containers/Bucket/PackageDialog/FilesInput.js 0.00% <0.00%> (ø)
...talog/app/containers/Bucket/PackageDialog/index.js 0.00% <0.00%> (ø)
...og/app/containers/Bucket/PackageDirectoryDialog.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/PackageTree.js 0.00% <ø> (ø)
...talog/app/containers/Bucket/PackageUpdateDialog.js 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8373a04...19db403. Read the comment docs.

@fiskus fiskus requested a review from nl0 February 1, 2021 15:16
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. the only thing i noticed after brief testing was that one can click on the drop area and trigger file selection dialog -- i think we should disable this when the files input is disabled.

@@ -47,6 +47,8 @@ const errorDisplay = R.cond([
</M.Typography>
</>
),
],
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohwow

@fiskus fiskus merged commit 85a996c into master Feb 12, 2021
@fiskus fiskus deleted the directory-to-package-dialog branch February 12, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants