Use EncodingType=url for S3 list* requests to handle special chars #2026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some weird key names (e.g. '\r\n') crash AWS SDK while performing list* operations, so we need to tell it explicitly to url-encode the keys (and then we need to manually decode them). However those keys still arent properly supported by the catalog -- they render with empty names and arent navigable (some quite involved refactoring required to fully handle this).