-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bucket admin link #2022
Bucket admin link #2022
Conversation
fiskus
commented
Jan 20, 2021
- Add ability to open Edit Dialog by providing URL query parameter
- Add link to Dialog from Bucket Overview
Codecov Report
@@ Coverage Diff @@
## master #2022 +/- ##
==========================================
- Coverage 46.85% 46.82% -0.03%
==========================================
Files 333 333
Lines 16704 16713 +9
Branches 2209 2234 +25
==========================================
Hits 7826 7826
- Misses 7963 7971 +8
- Partials 915 916 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. it would be nice to make the edit icon into a link instead of doing the redirect inside the click handler, but i suspect it's a little more involved and not required right now
It's simple to make an icon a link. But the table's row is also clickable. To make the table row a link I need to change the table's html/css layout. |
good to merge |