Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket admin link #2022

Merged
merged 10 commits into from
Jan 22, 2021
Merged

Bucket admin link #2022

merged 10 commits into from
Jan 22, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jan 20, 2021

  • Add ability to open Edit Dialog by providing URL query parameter
  • Add link to Dialog from Bucket Overview

Screenshot from 2021-01-20 11-06-05

@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #2022 (d9492bb) into master (16aad50) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
- Coverage   46.85%   46.82%   -0.03%     
==========================================
  Files         333      333              
  Lines       16704    16713       +9     
  Branches     2209     2234      +25     
==========================================
  Hits         7826     7826              
- Misses       7963     7971       +8     
- Partials      915      916       +1     
Flag Coverage Δ
api-python 89.36% <ø> (ø)
catalog 7.29% <0.00%> (-0.01%) ⬇️
lambda 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/constants/routes.js 0.00% <0.00%> (ø)
catalog/app/containers/Admin/Admin.js 0.00% <ø> (ø)
catalog/app/containers/Admin/Buckets.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Overview.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16aad50...d9492bb. Read the comment docs.

@fiskus fiskus requested a review from nl0 January 20, 2021 08:15
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. it would be nice to make the edit icon into a link instead of doing the redirect inside the click handler, but i suspect it's a little more involved and not required right now

catalog/app/containers/Bucket/Overview.js Outdated Show resolved Hide resolved
catalog/app/containers/Admin/Buckets.js Show resolved Hide resolved
@fiskus
Copy link
Member Author

fiskus commented Jan 21, 2021

t would be nice to make the edit icon into a link instead of doing the redirect inside the click handler

It's simple to make an icon a link. But the table's row is also clickable. To make the table row a link I need to change the table's html/css layout.

@nl0
Copy link
Member

nl0 commented Jan 22, 2021

good to merge

@fiskus fiskus merged commit 9b5b292 into master Jan 22, 2021
@fiskus fiskus deleted the bucket-admin-link branch January 22, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants