Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonEditor validation errors #2010

Merged
merged 9 commits into from
Jan 19, 2021
Merged

JsonEditor validation errors #2010

merged 9 commits into from
Jan 19, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jan 18, 2021

  • Move component that renders metadata errors outside JsonEditor to the PackageDialog level
  • Re-use PackageDialog JSON Schema validation for JsonEditor, remove validation from JsonEditor
  • Show JSON Schema validation errors for text mode too

@fiskus fiskus requested a review from nl0 January 18, 2021 14:16
@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 46.84%. Comparing base (56dee8e) to head (2f08471).
Report is 1805 commits behind head on master.

Files with missing lines Patch % Lines
...iners/Bucket/PackageDialog/MetaInputErrorHelper.js 0.00% 10 Missing and 1 partial ⚠️
...p/containers/Bucket/PackageDialog/PackageDialog.js 0.00% 2 Missing and 1 partial ⚠️
catalog/app/components/JsonEditor/JsonEditor.js 0.00% 0 Missing and 1 partial ⚠️
catalog/app/components/JsonEditor/State.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   46.81%   46.84%   +0.02%     
==========================================
  Files         333      333              
  Lines       16707    16698       -9     
  Branches     2214     2208       -6     
==========================================
  Hits         7822     7822              
+ Misses       7970     7962       -8     
+ Partials      915      914       -1     
Flag Coverage Δ
api-python 89.35% <ø> (ø)
catalog 7.30% <0.00%> (+<0.01%) ⬆️
lambda 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus merged commit 817ce14 into master Jan 19, 2021
@fiskus fiskus deleted the json-editor-metadata-errors branch January 19, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants