Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out deleted files from samples in lambda / ES #2003

Merged
merged 9 commits into from
Jan 17, 2021

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jan 15, 2021

depends on #2000

@nl0 nl0 requested a review from akarve January 15, 2021 13:24
@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #2003 (7bc4987) into master (dcd4d3a) will increase coverage by 0.01%.
The diff coverage is 13.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
+ Coverage   46.71%   46.72%   +0.01%     
==========================================
  Files         332      332              
  Lines       16450    16451       +1     
  Branches     2195     2191       -4     
==========================================
+ Hits         7684     7687       +3     
+ Misses       7867     7866       -1     
+ Partials      899      898       -1     
Flag Coverage Δ
api-python 89.35% <ø> (ø)
catalog 7.39% <0.00%> (+<0.01%) ⬆️
lambda 92.31% <42.85%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/Overview.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/PackageTree.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/requests.js 0.00% <0.00%> (ø)
catalog/app/utils/search.js 0.00% <0.00%> (ø)
lambdas/search/tests/test_search.py 100.00% <ø> (ø)
lambdas/search/index.py 86.02% <42.85%> (-2.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcd4d3a...7bc4987. Read the comment docs.

'terms': {
'field': 'key',
'order': [{'modified': 'desc'}],
'size': 1000000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment on this? It's way more than the JS client could handle? If we're trying to limit server-side work for performance reasons, tweaking MAX_DOCUMENTS_PER_SHARD will probably be faster.

Suggested change
'size': 1000000,
'size': 1000000,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're just setting it to smth larger than anticipated cardinality to use all values for aggregation

@akarve akarve merged commit ac28383 into master Jan 17, 2021
@akarve akarve deleted the filter-out-deleted-from-samples branch January 17, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants