-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out deleted files from samples in lambda / ES #2003
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
+ Coverage 46.71% 46.72% +0.01%
==========================================
Files 332 332
Lines 16450 16451 +1
Branches 2195 2191 -4
==========================================
+ Hits 7684 7687 +3
+ Misses 7867 7866 -1
+ Partials 899 898 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
'terms': { | ||
'field': 'key', | ||
'order': [{'modified': 'desc'}], | ||
'size': 1000000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment on this? It's way more than the JS client could handle? If we're trying to limit server-side work for performance reasons, tweaking MAX_DOCUMENTS_PER_SHARD will probably be faster.
'size': 1000000, | |
'size': 1000000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're just setting it to smth larger than anticipated cardinality to use all values for aggregation
depends on #2000