Add buttons for copying canonical package URIs #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akarve pls wordsmith |
Codecov Report
@@ Coverage Diff @@
## master #1990 +/- ##
==========================================
- Coverage 46.80% 46.77% -0.03%
==========================================
Files 332 332
Lines 16418 16428 +10
Branches 2209 2187 -22
==========================================
Hits 7684 7684
- Misses 7837 7846 +9
- Partials 897 898 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fiskus
reviewed
Dec 17, 2020
| @@ -84,6 +88,15 @@ function RevisionInfo({ revisionData, revision, bucket, name, path }) { | |||
| _: R.identity, | |||
| }) | |||
|
|
|||
| const getHttpsUri = (r) => | |||
| `${window.origin}${urls.bucketPackageTree(bucket, name, r.hash, path)}` | |||
There was a problem hiding this comment.
Hm... I expected quilt+s3:// url here
There was a problem hiding this comment.
Now it's the same URL as if you copy it by right click and select "Copy link location"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy current revision's uri:
copy any revision's uri:
TODO