Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree view for files in package update dialog #1989

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Dec 16, 2020

Screenshot 2020-12-16 at 22 14 34

TODO

  • Unit tests (probably in a follow-up PR)
  • Changelog entry

@nl0 nl0 requested review from fiskus and akarve December 16, 2020 17:13
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #1989 (23aa207) into master (05603fe) will decrease coverage by 0.27%.
The diff coverage is 2.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1989      +/-   ##
==========================================
- Coverage   47.07%   46.80%   -0.28%     
==========================================
  Files         332      332              
  Lines       16330    16418      +88     
  Branches     2197     2186      -11     
==========================================
- Hits         7688     7684       -4     
- Misses       7752     7837      +85     
- Partials      890      897       +7     
Flag Coverage Δ
api-python 89.35% <ø> (ø)
catalog 7.41% <2.17%> (-0.13%) ⬇️
lambda 92.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...talog/app/containers/Bucket/PackageUpdateDialog.js 0.00% <0.00%> (ø)
catalog/app/utils/tagged.js 78.72% <75.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05603fe...23aa207. Read the comment docs.

Copy link
Member

@fiskus fiskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any bugs with shallow testing. I'm going to test it more tomorrow (maybe on staging?).
The left sidebar is weird, otherwise, UX is good and predictable.

@nl0
Copy link
Member Author

nl0 commented Dec 17, 2020

  • less saturated colors
  • icon overlays (+/-/~)
  • "revert" icon -> "undo" icon

Screenshot 2020-12-17 at 11 56 05

@nl0 nl0 merged commit c754838 into master Dec 17, 2020
@nl0 nl0 deleted the pkg-update-tree-view branch December 17, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants