Support EventBridge events in lambdas/es/indexer, test event shape #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g eTag better, support EventBridge
Codecov Report
@@ Coverage Diff @@
## master #1987 +/- ##
==========================================
+ Coverage 46.74% 47.16% +0.42%
==========================================
Files 332 332
Lines 16439 16574 +135
Branches 2191 2214 +23
==========================================
+ Hits 7684 7817 +133
- Misses 7856 7858 +2
Partials 899 899
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… fix missing _op_type that would cause delete events to be missed
nl0
reviewed
Jan 11, 2021
…riggers events, as opposed to manifest keys
…rsion_id for packages and delete markers
Co-authored-by: Alexei Mochalov <[email protected]>
kevinemoore
approved these changes
Jan 12, 2021
| } | ||
| }, | ||
| # we delete synchronously, so don't let it linger too long | ||
| timeout='20s' |
There was a problem hiding this comment.
What happens if this times out?
There was a problem hiding this comment.
We don't do the delete. I could do this async.
nl0
reviewed
Jan 12, 2021
sir-sigurd
reviewed
Jan 12, 2021
sir-sigurd
reviewed
Jan 13, 2021
…ed with the tag so that _id primray key is always unique
Co-authored-by: Sergey Fedoseev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO