Immutable URIs WIP

[nl0]

Description

Add /uri/* route to resolve Quilt package URIs as per spec

TODO

• nice UI
• Unit tests
• Changelog entry
• use hashes for routing (Hash-based package routes #1938)

[codecov-io]

Codecov Report

Merging #1935 (88d7c5d) into master (3c87327) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1935   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files          64       64           
  Lines        7792     7792           
=======================================
  Hits         7044     7044           
  Misses        748      748           

Flag	Coverage Δ
api-python	89.35% <ø> (ø)
lambda	92.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c87327...88d7c5d. Read the comment docs.

[fiskus]

First shallow reading is done

[fiskus]

It cost me some brain cycles to realize where can I copy the package's URI. Even I saw it this morning. But I understand this was "quick implementation vs perfect UX" balanced. Maybe we can steal GitHub UI and show copy button near hash.

Also, I was expecting, that click on the "resolve" button will redirect to the resolved URL.

---

Possible problem: as a user I don't know how to close/hide "Resolved from URI" notification. As a developer, I can see, that some users can bookmark URL with query string or send it to a colleague and will be stuck with this notification.
We can redirect to the canonical URL automatically, or (and) add a close button to notification

---

Issues beyond the task's scope (or not, I don't know): errors are not helpful.

https:///b/fiskus-sandbox-dev/packages/fiskus/2020-11-1?resolvedFrom=quilt%2Bs3%3A%2F%2Ffiskus-sandbox-dev%23package%3Dfiskus%2F2020-11-1
Error: wrong revision, actually: wrong package

http://localhost:3000/b/fiskus-sandbox-dev/packages/fiskus/?resolvedFrom=quilt%2Bs3%3A%2F%2Ffiskus-sandbox-dev%23package%3Dfiskus%2F
Error: nothing here, do you need to log in, and exceptions in console. Actually, no such package, I'm logged in

[nl0]

It cost me some brain cycles to realize where can I copy the package's URI. Even I saw it this morning. But I understand this was "quick implementation vs perfect UX" balanced. Maybe we can steal GitHub UI and show copy button near hash.

gh ux doesnt fit here exactly, bc a button near a hash is expected to be related to that hash, not to the "canonical URI"

Also, I was expecting, that click on the "resolve" button will redirect to the resolved URL.

i think i'll implement this and ditch the package box

Possible problem: as a user I don't know how to close/hide "Resolved from URI" notification. As a developer, I can see, that some users can bookmark URL with query string or send it to a colleague and will be stuck with this notification.
We can redirect to the canonical URL automatically, or (and) add a close button to notification

i'll add a close btn

Issues beyond the task's scope (or not, I don't know): errors are not helpful.

https:///b/fiskus-sandbox-dev/packages/fiskus/2020-11-1?resolvedFrom=quilt%2Bs3%3A%2F%2Ffiskus-sandbox-dev%23package%3Dfiskus%2F2020-11-1
Error: wrong revision, actually: wrong package

well, we may want to add some check to see if the package actually exists (there's at least one revision of that package), but it seems out of scope, you're right

http://localhost:3000/b/fiskus-sandbox-dev/packages/fiskus/?resolvedFrom=quilt%2Bs3%3A%2F%2Ffiskus-sandbox-dev%23package%3Dfiskus%2F
Error: nothing here, do you need to log in, and exceptions in console. Actually, no such package, I'm logged in

it's a 404, bc the url doesnt match any route, which seems more or less correct

[fiskus]

Consider null exception