Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrossBucket push, frontend #1932

Merged
merged 107 commits into from
Dec 3, 2020
Merged

CrossBucket push, frontend #1932

merged 107 commits into from
Dec 3, 2020

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 20, 2020

  • CopyButton is an action button and bucket successor's select
  • CopyPackageDialog is copy-pasted from Create and Update dialog
  • I've split DialogForm into several components we can reuse for Update, Create and Copy dialogs. I suspect, there will be PushDirectory dialog
  • I've added some snapshot tests for small components

Hierarchy for new components:

PackageTree
 +- CopyButton
       "click" -> BucketsListFetcher 
                   +- Menu

 +- PackageCopyDialog
   +- PackageDialog.Error
   +- PackageDialog.Success
   +- PackageDialog.Loading
   +- DialogForm
       +- FilesInput -> Dropzone
                         +- Dropzone.Header
                         +- Dropzone.FileEntry[]
                         +- Dropzone.DropMessage
                        Dropzone.Overlay

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #1932 (dbd68c3) into master (e22cdcc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1932   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files          64       64           
  Lines        7792     7792           
=======================================
  Hits         7044     7044           
  Misses        748      748           
Flag Coverage Δ
api-python 89.35% <ø> (ø)
lambda 92.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22cdcc...dbd68c3. Read the comment docs.

catalog/app/utils/workflows.js Outdated Show resolved Hide resolved
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a possible bug related to error handling and async / await in onSubmit / requestPackageCopy, the rest looks good

catalog/app/containers/Bucket/PackageCopyDialog.js Outdated Show resolved Hide resolved
catalog/app/containers/Bucket/PackageCopyDialog.js Outdated Show resolved Hide resolved
@fiskus fiskus requested a review from nl0 December 2, 2020 13:53
@fiskus fiskus merged commit 0709a4f into master Dec 3, 2020
@fiskus fiskus deleted the crossbucket-push-frontend branch December 3, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants