Revision list from ES #1851
Revision list from ES #1851
Conversation
nl0
force-pushed
the
revision-list-from-es
branch
from
b2d1de0 to
a9ccd99
Compare
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
+ Coverage 88.72% 89.48% +0.75%
==========================================
Files 93 62 -31
Lines 11772 7244 -4528
==========================================
- Hits 10445 6482 -3963
+ Misses 1327 762 -565
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| <span className={classes.line}> | ||
| {r.message || <i>No message</i>} | ||
| </span> | ||
| <br /> |
There was a problem hiding this comment.
You already have .line class and it's nowraped, I think you can add display: block instead of <br />
| const t = M.useTheme() | ||
| const xs = M.useMediaQuery(t.breakpoints.down('xs')) | ||
| const sm = M.useMediaQuery(t.breakpoints.down('sm')) | ||
| // eslint-disable-next-line no-nested-ternary |
There was a problem hiding this comment.
no-nested-ternary rule is still a thing. Eslint shows warning on this
There was a problem hiding this comment.
yeah, i think it's ok to see those warnings and be aware of that
| ) | ||
| } | ||
|
|
||
| function RevisionSkel() { |
There was a problem hiding this comment.
The full name RevisionSkeleton would be more consistent
@akarve this one includes lambda changes