Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package list: show "push" button when no packages #1843

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Oct 7, 2020

TODO

quilt-bucket-onboarding

@nl0 nl0 requested a review from akarve October 7, 2020 17:29
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #1843 into master will decrease coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1843      +/-   ##
==========================================
- Coverage   89.48%   88.73%   -0.76%     
==========================================
  Files          62       93      +31     
  Lines        7237    11767    +4530     
==========================================
+ Hits         6476    10441    +3965     
- Misses        761     1326     +565     
Flag Coverage Δ
#api-python 87.70% <ø> (-0.18%) ⬇️
#lambda 92.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/quilt3/util.py 80.42% <0.00%> (-1.43%) ⬇️
api/python/tests/test_data_transfer.py 99.02% <0.00%> (-0.98%) ⬇️
api/python/quilt3/data_transfer.py 77.77% <0.00%> (-0.17%) ⬇️
...ircleci/project/api/python/quilt3/backends/base.py 89.20% <0.00%> (ø)
...sers/circleci/project/api/python/tests/conftest.py 92.68% <0.00%> (ø)
.../circleci/project/api/python/tests/test_formats.py 100.00% <0.00%> (ø)
...:/Users/circleci/project/api/python/quilt3/main.py 55.85% <0.00%> (ø)
...ers/circleci/project/api/python/quilt3/packages.py 91.85% <0.00%> (ø)
...ers/circleci/project/api/python/tests/test_util.py 100.00% <0.00%> (ø)
...ers/circleci/project/api/python/quilt3/registry.py 0.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e540c2a...01730f5. Read the comment docs.

@akarve akarve self-requested a review October 7, 2020 20:51
Copy link
Member

@akarve akarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start; we should merge but also backlog: if the user clicks Push Package, uses DND, and pushes, but then doesn't "browse" the package and closes window, then I think the list behind remains empty? Not sure if/how we can fix this but it might be a confusing UX.

@akarve akarve merged commit 10b7e4a into master Oct 8, 2020
@akarve akarve deleted the bucket-onboarding-push-pkg branch October 8, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants