-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package list: show "push" button when no packages #1843
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
==========================================
- Coverage 89.48% 88.73% -0.76%
==========================================
Files 62 93 +31
Lines 7237 11767 +4530
==========================================
+ Hits 6476 10441 +3965
- Misses 761 1326 +565
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start; we should merge but also backlog: if the user clicks Push Package, uses DND, and pushes, but then doesn't "browse" the package and closes window, then I think the list behind remains empty? Not sure if/how we can fix this but it might be a confusing UX.
TODO