Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog, Search: add help dropdown to the index landing page #1838

Merged
merged 16 commits into from
Nov 2, 2020

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Oct 7, 2020

Search Help has a slightly different look for Header and OpenLanding. I made NavBar/Help.js more abstract (in terms of styles) and reused for OpenLanding. Maybe I should move it to another place, ex. components/SearchHelp.js

demo

@fiskus fiskus changed the title Catalog, Search: add help dropdown to the index landing page [WIP] Catalog, Search: add help dropdown to the index landing page Oct 7, 2020
@fiskus fiskus changed the title [WIP] Catalog, Search: add help dropdown to the index landing page Catalog, Search: add help dropdown to the index landing page Oct 22, 2020
@fiskus fiskus marked this pull request as ready for review October 22, 2020 15:48
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #1838 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1838   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          62       62           
  Lines        7387     7387           
=======================================
  Hits         6636     6636           
  Misses        751      751           
Flag Coverage Δ
#api-python 88.43% <ø> (ø)
#lambda 92.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90249fd...85645e1. Read the comment docs.

@fiskus fiskus requested review from nl0 and akarve October 22, 2020 16:50
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good overall, but i think the huge rounded corners look a little out-of-place. i'd rather go for the standard border-radius, like this:
localhost_3000_(Laptop 2x)

catalog/app/containers/NavBar/Help.js Outdated Show resolved Hide resolved
@fiskus
Copy link
Member Author

fiskus commented Oct 26, 2020

the huge rounded corners look a little out-of-place. i'd rather go for the standard border-radius

Removed too much rounded corners as you propose

@fiskus fiskus requested a review from nl0 October 26, 2020 15:13
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested it after the most recent changes, but i believe it should be ok

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@fiskus fiskus merged commit 243d088 into master Nov 2, 2020
@fiskus fiskus deleted the search-help-landing-index branch November 2, 2020 09:53
fiskus added a commit that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants