-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog, Search: add help dropdown to the index landing page #1838
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 62 62
Lines 7387 7387
=======================================
Hits 6636 6636
Misses 751 751
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed too much rounded corners as you propose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't tested it after the most recent changes, but i believe it should be ok
Search Help has a slightly different look for Header and OpenLanding. I made
NavBar/Help.js
more abstract (in terms of styles) and reused for OpenLanding. Maybe I should move it to another place, ex.components/SearchHelp.js