Follow-up to #1829: Simplify condition #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sir-sigurd
commented
Oct 6, 2020
Comment on lines
+121
to
+123
| if not ( | ||
| package_stats is None | ||
| or isinstance(package_stats, dict) and {'total_files', 'total_bytes'}.issubset(package_stats) |
There was a problem hiding this comment.
This also makes the exception to be raised on non-dict falsy values which I think was expected.
Codecov Report
@@ Coverage Diff @@
## master #1833 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 62 62
Lines 7237 7237
=======================================
Hits 6476 6476
Misses 761 761
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
akarve
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.