Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive package filtering #1807

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Sep 18, 2020

No description provided.

@nl0 nl0 requested a review from akarve September 18, 2020 12:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #1807 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1807   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files          62       62           
  Lines        7194     7194           
=======================================
  Hits         6430     6430           
  Misses        764      764           
Flag Coverage Δ
#api-python 87.70% <ø> (ø)
#lambda 92.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b04b62...c51a83d. Read the comment docs.

@nl0 nl0 force-pushed the case-insensitive-package-filter branch from 694661d to c51a83d Compare September 18, 2020 12:49
Copy link
Member

@akarve akarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but can you up the debounce time? i think we should skeletonize immediately when input starts but wait 250 to 500 msec before flushing the query to ES

@akarve akarve merged commit 456c400 into master Sep 18, 2020
@akarve akarve deleted the case-insensitive-package-filter branch September 18, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants