Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple packet_numbers in frames_processed #168

Closed
rmarx opened this issue Jul 12, 2021 · 2 comments · Fixed by #307
Closed

Allow multiple packet_numbers in frames_processed #168

rmarx opened this issue Jul 12, 2021 · 2 comments · Fixed by #307

Comments

@rmarx
Copy link
Contributor

rmarx commented Jul 12, 2021

Currently, frames_processed only allows indicating a single packet_number.

However, discussion in #163 has shown that you might want to aggregate frames across multiple packets for some use cases, so it makes sense to make this into an Array<uint64> instead.

@kuroa-me
Copy link

About this structure

frames_processed : 
{
       frames:Array<QuicFrame>,
       packet_numbers?:Array<uint64>
}

How do we log the packet_numbers when we have multiple frames in one packet? My suggestion is we log them one to one.

Example (suppose fr1 and fr2 are in the same packet):

{
       frames:[fr1, fr2, fr3, fr4],
       packet_number:[1, 1, 2, 3]
}

This way we don't have to do any search when the packets arrive out of order.

@rmarx
Copy link
Contributor Author

rmarx commented Jul 14, 2021

Good point and your suggestion seems sensible :)

@rmarx rmarx self-assigned this Aug 18, 2021
LPardue added a commit that referenced this issue Jul 5, 2023
LPardue added a commit that referenced this issue Jul 5, 2023
* Support packet multiplicity in frames_processed

Closes #168


Co-authored-by: Robin Marx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants