-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant length fields #102
Comments
I kind of disagree, as I think an important use case is where you'd not want to log the raw values but only the lengths. We can argue whether that's the case for the CIDs of course, but for tokens and qpack data (and, obviously, payloads), I think people should have the option to not log the raw values. This flows from privacy/security concerns, as well as storage efficiency for larger deployments. I do think we could add text stating something like "if you log the raw values in hex, the length field is redundant, and tools SHOULD be able to derive length from hex"? |
Good point. I can see why you want to log tokens (since they create a correlation spanning two separate connections).
I'd make this an even stronger statement: ""if you log the raw values in hex, the length field is redundant and SHOULD (or MUST?) be omitted. Tools MUST be able to derive length from hex". |
Fixed by above commits. Main draft now explains how truncated raw byte values should be accompanied by a length field and that tools should be able to derive the length field from the raw byte values. Event definitions draft references this explicitly when discussing the RawInfo approach. |
Once we require hex-encoding for byte-fields (which, as far as I can see from other peoples' qlogs, is already the de-facto standard), we don't need length fields any more. This applies to the
scil
anddcil
in theHeader
(as well as the proposed token length in #94), theNewTokenFrame
,NewConnectionIDFrame
(and probably also the QPACK events, but I'm not an expert on those).The text was updated successfully, but these errors were encountered: