Clarify and split the "malformed" definition #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
force-pushed
the
http/what_is_malformed
branch
2 times, most recently
from
eb9f21a to
f5d137d
Compare
|
The Message Exchange section required that a client send precisely one request per stream, and that a server send precisely one final response (preceded by zero or more non-final responses), but how to deal with violations wasn't defined. This seems to fall in the same spirit of malformed messages, so I added that to the definition of "malformed." |
kazuho
approved these changes
Jan 16, 2020
LPardue
reviewed
Jan 17, 2020
MikeBishop
commented
Jan 17, 2020
martinthomson
approved these changes
Jan 20, 2020
martinthomson
added
the
design
ianswett
approved these changes
Jan 22, 2020
This was referenced Feb 4, 2020
MikeBishop
force-pushed
the
http/what_is_malformed
branch
from
c1bff0a to
5d0f2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of text, but it's basically all an import from RFC 7540 (which helps #3264, but doesn't totally resolve it). This makes the definition of malformed requests entirely local and more precise than previously.
The odd item on the malformed list was "extraneous frames." We're already fairly permissive about what other frames can show up interleaved with the actual request, so this requirement moved to that section -- receipt of DATA and HEADERS frames outside of the prescribed order is now a connection error.
Fixes #3345.