Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give IMMEDIATE_ACK a 1 byte codepoint #216

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Give IMMEDIATE_ACK a 1 byte codepoint #216

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79b5231
Change 0xaf to 0xaccf for the Ack Frequency Frame
ianswett Jul 25, 2023
0a1f4e5
Revert back to the 0xaf for ACK_FREQUENCY and pick next codepoint for…
ianswett Sep 9, 2023
4703b3a
Update draft-ietf-quic-ack-frequency.md
ianswett Sep 9, 2023
7378a27
Bump the transport param value
ianswett Sep 18, 2023
132e293
Update draft-ietf-quic-ack-frequency.md
mirjak Oct 16, 2023
2245919
request code points to IANA
mirjak Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-ietf-quic-ack-frequency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ ACK_FREQUENCY frame, shown below:

~~~
ACK_FREQUENCY Frame {
Type (i) = 0xaf,
Type (i) = 0xaccf,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Type (i) = 0xaccf,
Type (i) = TBD,

Sequence Number (i),
Ack-Eliciting Threshold (i),
Request Max Ack Delay (i),
Expand All @@ -221,7 +221,7 @@ ACK_FREQUENCY Frame {
~~~

Following the common frame format described in {{Section 12.4 of
QUIC-TRANSPORT}}, ACK_FREQUENCY frames have a type of 0xaf, and contain the
QUIC-TRANSPORT}}, ACK_FREQUENCY frames have a type of 0xaccf, and contain the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
QUIC-TRANSPORT}}, ACK_FREQUENCY frames have a type of 0xaccf, and contain the
QUIC-TRANSPORT}}, ACK_FREQUENCY frames have a type of TBD1, and contain the

following fields:

Sequence Number:
Expand Down Expand Up @@ -576,7 +576,7 @@ registry under the "QUIC Protocol" heading.

Value | Frame Name | Specification
-----------|---------------------|-----------------
0xaf | ACK_FREQUENCY | {{ack-frequency-frame}}
0xaccf | ACK_FREQUENCY | {{ack-frequency-frame}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
0xaccf | ACK_FREQUENCY | {{ack-frequency-frame}}
TBD1 | ACK_FREQUENCY | {{ack-frequency-frame}}

0xac | IMMEDIATE_ACK | {{immediate-ack-frame}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
0xac | IMMEDIATE_ACK | {{immediate-ack-frame}}
TBD2 | IMMEDIATE_ACK | {{immediate-ack-frame}}

{: #frame-types title="Addition to QUIC Frame Types Entries"}

mirjak marked this conversation as resolved.
Show resolved Hide resolved
Expand Down