Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final code point size #181

Closed
martinthomson opened this issue Mar 30, 2023 · 4 comments · Fixed by #216
Closed

Final code point size #181

martinthomson opened this issue Mar 30, 2023 · 4 comments · Fixed by #216
Labels

Comments

@martinthomson
Copy link
Member

I would like to propose that we choose a value for the final frame codepoint on the ACK_FREQUENCY frame that is from the 0x40-0x3fff range, so that the encoding takes two bytes. This is not going to be sent often.

For IMMEDIATE_ACK, a one byte coding might be useful to ensure that requesting acknowledgment is cheap.

@marten-seemann
Copy link
Contributor

Related: #119

@mirjak
Copy link
Contributor

mirjak commented Jun 7, 2023

We closed #199 as we didn't receive any further feedback from the group to change the code point. We can discuss again but it doesn't seem people have strong opinion and at some point we need to decide.

@LPardue
Copy link
Member

LPardue commented Jul 25, 2023

Discussed in IETF 117, feeling in the room is to use a 1-byte code point for IMMEDIATE_ACK and a 2-byte code point for ACK_FREQUENCY.

@ianswett
Copy link
Collaborator

ianswett commented Sep 2, 2023

ACK_FREQUENCY already has a 2-byte codepoint, but IMMEDIATE_ACK needs one and both should be registered with IANA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants