fix clippy #1927
Merged
fix clippy #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if it is not performance critical i'd rather have boxing T_T |
|
In this case there are a lot of tests that would need to be adjusted |
|
@PSeitz let's adjust the tests |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1927 +/- ##
========================================
Coverage 94.47% 94.47%
========================================
Files 309 309
Lines 56617 56775 +158
========================================
+ Hits 53489 53639 +150
- Misses 3128 3136 +8
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PSeitz
force-pushed
the
fix_clippy
branch
2 times, most recently
from
5a70efb to
2cf8ffb
Compare
fulmicoton
reviewed
Mar 8, 2023
src/aggregation/agg_tests.rs
Outdated
| @@ -590,7 +590,7 @@ fn test_aggregation_invalid_requests() -> crate::Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[cfg(all(test, feature = "unstable"))] | |||
| //#[cfg(all(test, feature = "unstable"))] | |||
There was a problem hiding this comment.
this is a mistake i believe?
fulmicoton
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix clippy