Add count, min, max, and sum aggregations #1794
Merged
+522
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the point of this PR. The goal is to catter for the need of subset of stats in quickwit API, correct? We can just call use the stats collector in quickwit and populate the reponse there. |
|
Discussed outside of this PR... Currently Quickwit directly relies on the deserialization of the aggregations object to convert a user request into a collector. This is not great, but this is what we have today. I'll open a separate ticket to have tantivy act more bottom-up, and allow the DSL logic to be done on quickwit side... |
|
Opened a ticket here #1796 |
fulmicoton
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.