handle user input on get_docid_for_value_range #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
get_docs_for_val_bug
branch
from
1406d82 to
5dd47cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #1760 +/- ##
========================================
Coverage 94.13% 94.14%
========================================
Files 267 267
Lines 50900 51129 +229
========================================
+ Hits 47917 48136 +219
- Misses 2983 2993 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Jan 9, 2023
| /// | ||
| /// coerce_up means the next valid upper value in the value space will be chosen if the value | ||
| /// has to be coerced. | ||
| fn mapping_coerce(&self, inp: External, _coerce_up: bool) -> (bool, Internal) { |
There was a problem hiding this comment.
Would something like .map_lower_than(&self, bound: Bound<To>) -> Bound<From> do the job?
If it would, I feel like the contract is more obvious.
There was a problem hiding this comment.
We could pass a Range in mapping_coerce instead (we don't have bounds here anymore). We still need the early exit for correctness if both map in front of the value space, and for that return a 1..0 range.
PSeitz
force-pushed
the
get_docs_for_val_bug
branch
3 times, most recently
from
0ddaa81 to
e30f74b
Compare
PSeitz
force-pushed
the
get_docs_for_val_bug
branch
from
e30f74b to
5ea89f5
Compare
fulmicoton
reviewed
Jan 12, 2023
fulmicoton
approved these changes
Jan 12, 2023
PSeitz
force-pushed
the
get_docs_for_val_bug
branch
from
5ea89f5 to
8962cfd
Compare
This was referenced Jan 12, 2023
Closed
fulmicoton
pushed a commit
that referenced
this pull request
Jan 16, 2023
* handle user input on get_docid_for_value_range fixes #1757 * pass range as parameter
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
* handle user input on get_docid_for_value_range fixes quickwit-oss#1757 * pass range as parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1757