-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aggregation support for date type #1693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 94.04% 94.07% +0.02%
==========================================
Files 256 257 +1
Lines 49169 49452 +283
==========================================
+ Hits 46243 46522 +279
- Misses 2926 2930 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PSeitz
force-pushed
the
date_in_agg
branch
2 times, most recently
from
November 24, 2022 01:56
40c9d6c
to
f79276e
Compare
fulmicoton
approved these changes
Nov 28, 2022
ppodolsky
pushed a commit
to izihawa/tantivy
that referenced
this pull request
Dec 8, 2022
* add aggregation support for date type fixes quickwit-oss#1332 * serialize key_as_string as rfc3339 in date histogram * update docs * enable date for range aggregation
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for date type in aggregations
Histogram
return additionally
key_as_string
formatted asRfc3339
Range
return additionally
from_as_string
,to_as_string
formatted asRfc3339
.Currently unsupported: pass ranges as formatted text.