Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstScoreQuery #1463

Merged
merged 5 commits into from
Aug 23, 2022
Merged

ConstScoreQuery #1463

merged 5 commits into from
Aug 23, 2022

Conversation

shikhar
Copy link
Collaborator

@shikhar shikhar commented Aug 23, 2022

Based this on BoostQuery, was able to reuse the existing ConstScorer.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #1463 (c392357) into main (67d94f5) will decrease coverage by 0.02%.
The diff coverage is 72.60%.

@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   94.07%   94.04%   -0.03%     
==========================================
  Files         238      239       +1     
  Lines       44564    44637      +73     
==========================================
+ Hits        41922    41978      +56     
- Misses       2642     2659      +17     
Impacted Files Coverage Δ
src/query/mod.rs 100.00% <ø> (ø)
src/query/const_score_query.rs 72.60% <72.60%> (ø)
src/indexer/segment_writer.rs 96.40% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shikhar shikhar force-pushed the const-score-query branch from 778154b to 5e88a51 Compare August 23, 2022 01:20
@shikhar shikhar marked this pull request as ready for review August 23, 2022 01:28
Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the ConstScorer in there too?

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix clippy

@fulmicoton fulmicoton merged commit 4c6c6e4 into main Aug 23, 2022
@fulmicoton fulmicoton deleted the const-score-query branch August 23, 2022 21:37
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants