Add possibility to set up highlighten prefix and postfix for snippet #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Aug 26, 2022
fulmicoton
reviewed
Aug 26, 2022
fulmicoton
force-pushed
the
main
branch
2 times, most recently
from
e550a98 to
84e0c75
Compare
|
Thank you for review! Did these fixes and reduced test. |
|
@fulmicoton hi, what the status with this feature? |
|
@PSeitz hey, can you help with review, please? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1422 +/- ##
==========================================
+ Coverage 94.47% 94.48% +0.01%
==========================================
Files 319 319
Lines 59404 59460 +56
==========================================
+ Hits 56119 56178 +59
+ Misses 3285 3282 -3
|
PSeitz
reviewed
May 10, 2023
src/snippet/mod.rs
Outdated
| @@ -101,6 +115,12 @@ impl Snippet { | |||
| pub fn highlighted(&self) -> &[Range<usize>] { | |||
| &self.highlighted | |||
| } | |||
|
|
|||
| /// Sets highlighted prefix and postfix. | |||
| pub fn set_highlighted_elements(&mut self, prefix: &str, postfix: &str) { | |||
There was a problem hiding this comment.
Suggested change
| pub fn set_highlighted_elements(&mut self, prefix: &str, postfix: &str) { | |
| pub fn set_snippet_prefix_postfix(&mut self, prefix: &str, postfix: &str) { |
src/snippet/mod.rs
Outdated
| @@ -55,17 +58,28 @@ impl FragmentCandidate { | |||
| pub struct Snippet { | |||
| fragment: String, | |||
| highlighted: Vec<Range<usize>>, | |||
| highlighting_prefix: String, | |||
There was a problem hiding this comment.
Suggested change
| highlighting_prefix: String, | |
| snippet_prefix: String, |
src/snippet/mod.rs
Outdated
| @@ -55,17 +58,28 @@ impl FragmentCandidate { | |||
| pub struct Snippet { | |||
| fragment: String, | |||
| highlighted: Vec<Range<usize>>, | |||
| highlighting_prefix: String, | |||
| highlighting_postfix: String, | |||
There was a problem hiding this comment.
Suggested change
| highlighting_postfix: String, | |
| snippet_postfix: String, |
PSeitz
approved these changes
May 23, 2023
|
@lavrd Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a possibility to change highlight prefix and postfix for snippets.