-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for phrase slop in query language #1393
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
+ Coverage 94.29% 94.33% +0.03%
==========================================
Files 236 236
Lines 43418 43643 +225
==========================================
+ Hits 40942 41170 +228
+ Misses 2476 2473 -3
Continue to review full report at Codecov.
|
For naming I think matching distance is much better than slop |
a51d3eb
to
1008bd5
Compare
I gave a quick look, I should be able to plug in the fuzzy query for bare words with the |
@fulmicoton @PSeitz so we keep slop in the Can we define "it" as being an |
132ef50
to
09b5c47
Compare
09b5c47
to
df475b1
Compare
Right now let's not handle fuzzy query in the grammar, it would break quickwit. |
5060251
to
b2e5dc8
Compare
b2e5dc8
to
53fcc33
Compare
I've got this PR https://github.com/saroh/tantivy/pull/1/files which I can push in here or open later. Adds support for "foo"~1, no changes to the query language. |
Breaking changes to the existing query language:
~
is now allowed unescaped in the field nameThe first commit still allows
~
in words, might be a bit flimsy.Second one exposes distance for all leaves. Do we need to explicitly fail for leaves that do not handle slop/distance + implement it for those who do ? (Term maybe, I haven't checked)
Not realy sure on the name, slop is hard to understand, distance is maybe a little to vague.
closes #1390