-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean fields #1382
Add boolean fields #1382
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
- Coverage 94.26% 94.19% -0.08%
==========================================
Files 235 235
Lines 42896 43186 +290
==========================================
+ Hits 40437 40680 +243
- Misses 2459 2506 +47
Continue to review full report at Codecov.
|
Nice job. Checkout |
@PSeitz @boraarslan Should we merge? @PSeitz Do we have a mechanism to use the field type to change the fastfield codec logic? It would be nice to force a bitset codec actually... Maybe even drop the DynamicReader for booleans. |
Calling |
@boraarslan @PSeitz Any update? |
LGTM, setting the codec can imo be done in another PR |
I agree with @PSeitz but If codec change is a must have I can look into that in this PR. |
@PSeitz Can you have approve & merge the PR? |
The first draft to add boolean field support. There is a very high chance I missed some stuff.
I will update the docs after the review (in case of something needs to change)