Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't create a custom MergePolicy, because part of the signature is in a private module #1235

Closed
kmitchener opened this issue Dec 10, 2021 · 1 comment · Fixed by #1237
Closed

Comments

@kmitchener
Copy link

Describe the bug
Attempt to create a custom MergePolicy, but it requires you to return a MergeCandidate which is private.

Which version of tantivy are you using?
0.16.1

To Reproduce
Try to create a custom MergePolicy.

error[E0603]: module `indexer` is private
   --> src\lib.rs:71:82
    |
71  |     fn compute_merge_candidates(&self, segments: &[SegmentMeta]) -> Vec<tantivy::indexer::merge_policy::MergeCandidate> {
    |                                                                                  ^^^^^^^ private module
    |

If your bug is deterministic, can you give a minimal reproducing code?
Some bugs are not deterministic. Can you describe with precision in which context it happened?
If this is possible, can you share your code?

@fulmicoton
Copy link
Collaborator

Thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants