Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict maturity period to retention #5543

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

reduce time before maturity of a split based on time to end of retention
reduce likelihood of encountering #5431 . It can technically still happen if a split is subject to merge at time t, its merge start, and then subject deletion at time t+1 while the merge is still running, but that should be a much rarer occurrence.

How was this PR tested?

added unit test for new code

@trinity-1686a trinity-1686a merged commit db1751b into main Nov 8, 2024
4 of 5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/prevent-merge-after-retention branch November 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants