-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Quickwit enterprise license. #5529
base: main
Are you sure you want to change the base?
Conversation
|
||
#[derive(Debug)] | ||
pub struct License { | ||
pub license_level: LicenseLevel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to be able to enable features separately, we would need something more here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can stick to license level, at least for the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not pick that from a specific license, and I am not sure of the origin of this formulation: you can google "license" "may only be used in production" to see a bunch of examples.
8097908
to
d5445e5
Compare
// With regard to the Quickwit Software: | ||
// | ||
// This software and associated documentation files (the "Software") may only be | ||
// used in production, if you (and any entity that you represent) hold a valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the production part should allow test use cases, but the wording is not clear, e.g. it can be understand as it can only be used in production and nowhere else.
Maybe we can remove the production part, and it can be covered by "Quickwit Enterprise license corresponding to your usage". We would need to emit access tokens anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wording used in several other famous license. It should be ok.
8755615
to
27106a8
Compare
Hey @fulmicoton, to be clear after this change, is an enterprise license required for internal production use cases of Quickwit? |
No. It is just for specific new features. |
No description provided.