Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Quickwit enterprise license. #5529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fulmicoton
Copy link
Contributor

No description provided.

@fulmicoton fulmicoton requested a review from PSeitz October 28, 2024 08:29
Copy link

github-actions bot commented Oct 28, 2024

On SSD:

Average search latency is 1.01x that of the reference (lower is better).
Ref run id: 4045, ref commit: 105aa7d
Link

On GCS:

Average search latency is 0.906x that of the reference (lower is better).
Ref run id: 4046, ref commit: 105aa7d
Link


#[derive(Debug)]
pub struct License {
pub license_level: LicenseLevel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to be able to enable features separately, we would need something more here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can stick to license level, at least for the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not pick that from a specific license, and I am not sure of the origin of this formulation: you can google "license" "may only be used in production" to see a bunch of examples.

@fulmicoton fulmicoton force-pushed the license branch 8 times, most recently from 8097908 to d5445e5 Compare November 1, 2024 01:41
// With regard to the Quickwit Software:
//
// This software and associated documentation files (the "Software") may only be
// used in production, if you (and any entity that you represent) hold a valid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the production part should allow test use cases, but the wording is not clear, e.g. it can be understand as it can only be used in production and nowhere else.

Maybe we can remove the production part, and it can be covered by "Quickwit Enterprise license corresponding to your usage". We would need to emit access tokens anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wording used in several other famous license. It should be ok.

@fulmicoton fulmicoton force-pushed the license branch 2 times, most recently from 8755615 to 27106a8 Compare November 1, 2024 02:24
@fulmicoton fulmicoton marked this pull request as ready for review November 1, 2024 02:38
@altanozlu
Copy link

Hey @fulmicoton, to be clear after this change, is an enterprise license required for internal production use cases of Quickwit?

@fulmicoton
Copy link
Contributor Author

No. It is just for specific new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants