Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry on S3 internal error #5504

Merged
merged 1 commit into from
Oct 21, 2024
Merged

retry on S3 internal error #5504

merged 1 commit into from
Oct 21, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

retry on S3 InternalError, it's most likely transient, despite not being marked as it in the sdk

@trinity-1686a trinity-1686a enabled auto-merge (squash) October 21, 2024 08:02
@trinity-1686a trinity-1686a merged commit 5e5b360 into main Oct 21, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/retry-internal-error branch October 21, 2024 08:08
@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 3920, ref commit: 57062ce
Link

On GCS:

Average search latency is 0.973x that of the reference (lower is better).
Ref run id: 3921, ref commit: 57062ce
Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trinity-1686a @fulmicoton