Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test #5391

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix flaky test #5391

merged 3 commits into from
Sep 5, 2024

Conversation

trinity-1686a
Copy link
Contributor

fix flakiness in test_garbage_collect_fails_to_run_delete_on_one_index introduced in #5380
the test depends of the order in which we iterate over the map. Fixed by finishing the iteration before aborting the gc run

@trinity-1686a trinity-1686a enabled auto-merge (squash) September 5, 2024 15:06
@trinity-1686a trinity-1686a merged commit 6768d01 into main Sep 5, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/fix-test branch September 5, 2024 15:24
Copy link

github-actions bot commented Sep 5, 2024

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 3278, ref commit: f49b253
Link

On GCS:

Average search latency is 0.972x that of the reference (lower is better).
Ref run id: 3280, ref commit: f49b253
Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants