Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky postgres tests #5340

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix flaky postgres tests #5340

merged 2 commits into from
Aug 26, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Aug 23, 2024

Description

Postgres tests tend to fail in coverage CI runs.

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this Aug 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

On SSD:

Average search latency is 0.999x that of the reference (lower is better).
Ref run id: 3009, ref commit: e3927eb
Link

On GCS:

Average search latency is 0.971x that of the reference (lower is better).
Ref run id: 3010, ref commit: e3927eb
Link

@rdettai rdettai marked this pull request as ready for review August 26, 2024 15:17
@rdettai rdettai requested a review from trinity-1686a August 26, 2024 15:18
@rdettai rdettai force-pushed the flaky-posgres-tests branch from a27041a to cb8fdb8 Compare August 26, 2024 15:19
trinity-1686a
trinity-1686a approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@rdettai rdettai enabled auto-merge (squash) August 26, 2024 15:19
@rdettai rdettai merged commit 4317e09 into main Aug 26, 2024
5 checks passed
@rdettai rdettai deleted the flaky-posgres-tests branch August 26, 2024 15:32
@rdettai rdettai mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

Assignees

@rdettai rdettai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdettai @trinity-1686a